Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements '*'(expand all) field selector. Closes: #147 #228

Merged
merged 3 commits into from
Jan 15, 2019

Conversation

Dragomir-Ivanov
Copy link
Contributor

No description provided.

smyrman
smyrman previously approved these changes Jan 10, 2019
Copy link
Collaborator

@smyrman smyrman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

schema/query/projection_evaluator.go Outdated Show resolved Hide resolved
smyrman
smyrman previously approved these changes Jan 10, 2019
Copy link
Collaborator

@smyrman smyrman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rs, any views?

@Dragomir-Ivanov
Copy link
Contributor Author

Dragomir-Ivanov commented Jan 11, 2019

@smyrman This is whole revamped version of the functionality. There is a lot to digest, so take your time with the review.

Fixes `schema.Array` behaviour with `schema.Reference`.
Adds projection validation to items within `schema.Array`.
@Dragomir-Ivanov
Copy link
Contributor Author

Dragomir-Ivanov commented Jan 12, 2019

It may be more easy checking out my repo, and review with:

git diff b810f68..HEAD

Because the patch on this PR, reverts part of my previous work on arrays of schema.Reference that is already upstream.

Copy link
Collaborator

@smyrman smyrman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good to me.

schema/query/projection_evaluator.go Show resolved Hide resolved
schema/query/projection_evaluator.go Outdated Show resolved Hide resolved
smyrman
smyrman previously approved these changes Jan 14, 2019
…place holder for other async resource (Reference,Connection)
@smyrman smyrman merged commit 2f104c4 into rs:master Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants