Enable dotSize in the MDS plot to be adjustable #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the original version, dotSize in the MDS plot could not be adjusted by users. Reason identified: The dotSize parameter is stored in userOption instead of localOptions, but the old script mistakenly tried to retrieve the dotSize information from the localOption. I edited the code so that dotSize is now rerived from the correct variable.
|
This appears to be a duplicate of #28, so I'm closing it. Please let me know if I've done this in error! |
|
Sorry I was just uncertain if the pull request should be aimed at the develop branch or the master one or both. |
|
No problem. I think we put non-emergency fixes and improvements onto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original version, dotSize in the MDS plot could not be adjusted by users.
Reason identified:
The dotSize parameter is stored in userOption instead of localOptions, but the old script mistakenly tried to retrieve the dotSize information from the localOption. I edited the code so that dotSize is now rerived from the correct variable.