Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue: fix nil pointer dereference on plumb error #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

issue: fix nil pointer dereference on plumb error #6

wants to merge 2 commits into from

Commits on Jan 12, 2020

  1. issue: fix nil pointer dereference on plumb error 

    plumbserve() fails with a nil pointer dereference when it tries to
print errors via w.Err(). This happens because w is a dummy window
with a nil *acme.Win. This commit  replaces w.Err() calls in
plumbserve() with acme.Errf(). It also extracts the plumbserve()
method out of *awin, given that the previous change removes this
dependency.

Fixes issue rsc#5.
    @jroimartin
    jroimartin committed Jan 12, 2020
    Configuration menu
    Copy the full SHA
    6cc4f0b View commit details
    Browse the repository at this point in the history

  2. issue: document plumb port requirement 

    Document "githubissue" plumb port requirement and how to create
it under the section "Acme Editor Integration".
    @jroimartin
    jroimartin committed Jan 12, 2020
    Configuration menu
    Copy the full SHA
    087a7d8 View commit details
    Browse the repository at this point in the history