WIP/RequestForFeedback/Discussion PR to add MSVC build capability #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o current libmbus
This reverts commit 0cf4843.
This reverts commit 68dfbba.
# Do not touch the line above. # Everything below will be removed. # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # # On branch build-windows # Your branch is up-to-date with 'origin/build-windows'. # # Changes to be committed: # # modified: mbus/mbus-serial.c # modified: mbus/mbus-tcp.c
As long as cmake doesn't generate suitable deb packages, we need to switch back :(
Apollon77
force-pushed
the
build-windows
branch
from
2b17eb1 to
646d3c2
Compare
# Conflicts: # .travis.yml # mbus/mbus-protocol-aux.h # test/generate-xml.sh
# Conflicts: # .travis.yml
This hack makes mbus_data_record_decode print errors still as hex, but allow negative BCD values for the rest. (cherry picked from commit 48d25a8)
(cherry picked from commit f775d19)
* Rewritten TCP connection to support IPv6 and get rid of deprecated gethostbyname Signed-off-by: Petr Kracík <petrkr@petrkr.net> (cherry picked from commit cb28aca)
Bug: serial baud rate 1200
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR is not really for "accepting" but to start a feedback/discussion/enhancement round :-)
I hope this is ok.
While working on my nodejs native module for libmbus (https://github.com/Apollon77/node-mbus) I also started liiking into windows build capability and I managed to get it build on windows (currently the lib only, but adding the executables should be no big deal if someone knows how :-))
I did the following (and those are the changes in this PR):
With these changes I was able to work with Serial and TCP on Windows too and I use this branch in my nodejs native module already.
It would be great to get feedback from you on this ... Especially about what your opinion if for Win support and such :-)
Ingo