Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to upload large files on MacOS #18

Open
rschroll opened this issue Mar 7, 2021 · 4 comments
Open

Failure to upload large files on MacOS #18

rschroll opened this issue Mar 7, 2021 · 4 comments

Comments

@rschroll
Copy link
Owner

rschroll commented Mar 7, 2021

This is continuing the discussion in #2.

There, it was discovered that large files were not being uploaded correctly on MacOS. It appears that the beginning of the file was full of \x00 bytes. This kept us from figuring out the file type, but presumably this would also cause the file as uploaded to be broken. The same files that cause this problem work fine on a Linux system, so it's something specific to the Mac, it seems.

A couple of possibilities:

  1. MacOS is writing the file full of null bytes first. Not sure why it would do this, nor why it only does this for large files.
  2. Something is going wrong in llfuse, which is being used for MacOS. But I can't reproduce it with llfuse on Linux.
  3. Something is going wrong in MacFuse.
@rschroll rschroll mentioned this issue Mar 7, 2021
@rschroll
Copy link
Owner Author

A bit of a shot in the dark, but if you're willing to try something, @AaronDavidSchneider:

Let's try setting stats.f_bsize = stats.f_frsize = 0 here: https://github.com/rschroll/rmfuse/blob/master/rmfuse/fuse.py#L486. Another filesystem I saw specifically set these to zero for Macs, although I couldn't make out why. We'll also have to adjust the next line to avoid a divide-by-zero error. The right-hand side change be changed from 2**32 / stats.f_frsize to 2**32 / 4096, or any other large number, presumably.

I'm not too hopeful that this solves the problem, but I haven't had any better ideas, I'm afraid.

@AaronDavidSchneider
Copy link

Hi,
I just tried it. Unfortunately nothing changed. Large files (like the flight plan still do not work)

@rschroll
Copy link
Owner Author

rschroll commented Mar 19, 2021 via email

@nils-werner
Copy link

I am really curious about this bug... Did you ask the FUSE devs? Do you have a link to that discussion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants