Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes #104

Merged
merged 2 commits into from
Feb 17, 2020
Merged

Minor fixes #104

merged 2 commits into from
Feb 17, 2020

Conversation

ig-sinicyn
Copy link
Contributor

  • Fix overload resolution on array.Reverse()
  • Update packages
  • Fix indexed item equality comparison (item index was ignored).

@ig-sinicyn ig-sinicyn requested review from NN--- and andrewvk February 16, 2020 16:04
@ig-sinicyn
* Fix overload resolution on array.Reverse()
57985cd 
* Update packages
* Fix indexed item equality comparison (item index was ignored).
@ig-sinicyn ig-sinicyn force-pushed the feature/fix-overload-conflict branch from 520321c to 57985cd Compare February 16, 2020 16:12
NN---
NN--- approved these changes Feb 16, 2020
View reviewed changes
Copy link
Member

@NN--- NN--- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would do separate commit for package update

@ig-sinicyn ig-sinicyn merged commit f91ab23 into master Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NN--- NN--- NN--- approved these changes

@andrewvk andrewvk Awaiting requested review from andrewvk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ig-sinicyn @NN---