-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically build new Intel OneAPI versions #55
Conversation
cc @mdavis36 |
That was so fast! |
uptodate makes it so easy! |
@@ -2,8 +2,9 @@ dockerbuild: | |||
build_args: | |||
intel_version: | |||
key: intel | |||
versions: | |||
- "2021.2.0" | |||
name: intel-oneapi-compilers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this being passed into the Dockerfile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh nevermind, you are updating an existing one right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, the intel
key is used in the existing Dockerfile to drive the Spack install. This change means the versions will come from the Spack package, rather than the list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidbeckingsale I see this building 2021.4 as the latest, any chance of getting a 2022 build or is this a limitation of the spack packages for oneapi?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be finding the versions in the Spack package, which has up to 2022.0.1 - let me figure out what's going on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the following on the "Action" tab:
This scheduled workflow is disabled because there hasn't been activity in this repository for at least 60 days. Enable this workflow to resume scheduled runs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm re-running it now. It's weird normally I get an email notification but because this isn't my org I didn't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are going through the same steps at the same speed 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need github actions to update our actions
oh no someone turned off my action ! https://github.com/spack/packages :( |
okay it's fixed! Sorry for the delay - spack changed the structure of variants and introduced a bug in the parser that I had to fix. https://spack.github.io/packages/package.html?name=intel-oneapi-compilers |
@davidbeckingsale should we re-run this to make sure the 2022 versions build? |
okay the re-run has TBA with 2022, we can merge when they all pass https://github.com/rse-ops/docker-images/runs/4863067135?check_suite_focus=true |
No description provided.