Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically build new Intel OneAPI versions #55

Merged
merged 2 commits into from
Jan 19, 2022

Conversation

davidbeckingsale
Copy link
Collaborator

No description provided.

@davidbeckingsale
Copy link
Collaborator Author

cc @mdavis36

@davidbeckingsale davidbeckingsale mentioned this pull request Jan 18, 2022
16 tasks
@vsoch
Copy link
Contributor

vsoch commented Jan 18, 2022

That was so fast!

@davidbeckingsale
Copy link
Collaborator Author

That was so fast!

uptodate makes it so easy!

@@ -2,8 +2,9 @@ dockerbuild:
build_args:
intel_version:
key: intel
versions:
- "2021.2.0"
name: intel-oneapi-compilers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this being passed into the Dockerfile?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh nevermind, you are updating an existing one right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, the intel key is used in the existing Dockerfile to drive the Spack install. This change means the versions will come from the Spack package, rather than the list.

Copy link

@mdavis36 mdavis36 Jan 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidbeckingsale I see this building 2021.4 as the latest, any chance of getting a 2022 build or is this a limitation of the spack packages for oneapi?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be finding the versions in the Spack package, which has up to 2022.0.1 - let me figure out what's going on.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ug it was GitHub!! Poozers.
image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the following on the "Action" tab:

This scheduled workflow is disabled because there hasn't been activity in this repository for at least 60 days. Enable this workflow to resume scheduled runs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm re-running it now. It's weird normally I get an email notification but because this isn't my org I didn't.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are going through the same steps at the same speed 😆

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need github actions to update our actions

@vsoch
Copy link
Contributor

vsoch commented Jan 18, 2022

oh no someone turned off my action ! https://github.com/spack/packages :(

@vsoch
Copy link
Contributor

vsoch commented Jan 18, 2022

okay it's fixed! Sorry for the delay - spack changed the structure of variants and introduced a bug in the parser that I had to fix. https://spack.github.io/packages/package.html?name=intel-oneapi-compilers

@vsoch
Copy link
Contributor

vsoch commented Jan 19, 2022

@davidbeckingsale should we re-run this to make sure the 2022 versions build?

@vsoch
Copy link
Contributor

vsoch commented Jan 19, 2022

okay the re-run has TBA with 2022, we can merge when they all pass https://github.com/rse-ops/docker-images/runs/4863067135?check_suite_focus=true

@davidbeckingsale davidbeckingsale merged commit 3697566 into main Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants