Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve examples #94

Open
2 of 4 tasks
Neves-P opened this issue Mar 18, 2020 · 2 comments
Open
2 of 4 tasks

Improve examples #94

Neves-P opened this issue Mar 18, 2020 · 2 comments
Assignees

Comments

@Neves-P
Copy link
Collaborator

Neves-P commented Mar 18, 2020

Quoting richelbilderbeek (not tagging so as to not spam more) in #90:

These examples can definitely be improved.

Example code should be runnable, simple and clean.
Instead, it is complex and does not even run!
As a user, I want example code that is guaranteed to be correct,
that is, checked by R CMD check. Please make the code do something simple.

I do see the function is mostly a redirection function already, depending
on the diversity dependence model. You'll see that below I will request that
this function does even more so. Do add example code for each possible flow
through this function, which are ?four models (CS 5 pars, CS 10 pars, IW and GW).

Make code:

  • Runnable
  • Simple
  • Cover each possible flow
  • Pass R CMD check
@richelbilderbeek
Copy link
Collaborator

What, you think you can avoid the Eye of Sauron 😎 ?

@Neves-P
Copy link
Collaborator Author

Neves-P commented Mar 18, 2020

What, you think you can avoid the Eye of Sauron 😎 ?

Never, and we're all the better for it! 👁
Thanks, Richel! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants