Added size and mtime properties to item #13
Conversation
…unded by dashes or colons
-- added mtime and size properties to item -- added methods to sequence to get max mtime and size for the sequence object -- added reindex function can change padding too
| @@ -733,7 +805,7 @@ def getSequences(source): | |||
| items = sorted(source, key=lambda x: str(x)) | |||
| elif isinstance(source, str): | |||
| if os.path.isdir(source): | |||
| items = sorted(glob(os.path.join(source, '*'))) | |||
| items = sorted(glob(os.path.join(source, '*.*'))) | |||
There was a problem hiding this comment.
Added the . as getSequence is returning folders which I dont think it should
There was a problem hiding this comment.
Hmm, not sure about this one. This assumes only files with a "." in the name are valid sequences, but that may not always be true. Perhaps this kind of thing should be configurable, however (see issue #5).
There was a problem hiding this comment.
I have been using this to get rid of folders from getSequences.
It should only find files with an extension . ...
In my fork I had this with a keyword (folder=False)
elif type(source) == str and os.path.isdir(source) and folders:
items = sorted(glob(os.path.join(source, '')))
elif type(source) == str and os.path.isdir(source) and not folders:
items = sorted(glob(os.path.join(source, '.*')))
but maybe it is better than to filter folders out specifically instead of globbing only for files with a .
I ll remove that for now.
|
Thanks, Johannes. These seem like useful updates, along the lines of issue #6. I wish I had started this project following strict PEP8 guidelines, but at this point I think the methods should be named consistently at least, even if they're not PEP8. So, do you mind renaming a couple of these? get_max_mtime -> getMaxMTime
get_size -> getSizeAlso, for doc strings, seems like we are following the convention of double-quotes: """some useful docs here
"""Also, I'd like to add you to the AUTHORS file. How do you want to be credited? edit: looking forward to the s3d updates |
| tempSize.append(i.size) | ||
| return sum(tempSize) | ||
|
|
||
| def reIndex(self, addSub, padding=None, run=False): |
There was a problem hiding this comment.
If you're increasing the frame numbers, couldn't this possibly overwrite files? Adding 5 on a range of 1001-1010 would move 1001 to 1006 before 1006 has been moved.
I'd recommend reversing your for loop if the addSub is > 0, and keeping it like it is if addSub < 0
There was a problem hiding this comment.
Yep you are right, changed that too.
Thanks a ton for the hint.
-- method Names are camelCase for now -- had to change item.__dirname to use self.__path as it was missing on the first item, though I do not know why….
| @@ -86,11 +86,17 @@ def __init__(self, item): | |||
| log.debug('adding %s' % item) | |||
| self.item = item | |||
| self.__path = getattr(item, 'path', os.path.abspath(str(item))) | |||
| self.__dirname = os.path.dirname(str(item)) | |||
| self.__dirname = os.path.dirname(self.__path) | |||
There was a problem hiding this comment.
Maybe someone understands why, but dirname was missing on the last item when using str(item), now when using self.__path it is always present...
and wasnot there a dirname on the sequence object too ?
|
hey Ryan, regarding the authors file... cheers |
|
Thanks, guys. These updates are useful. Re-thinking about getSize and getMaxMTime, I wonder if it'd be preferable to keep naming parity with the Item class (sorry, Johannes, I know I asked you to change it to this). That way the accesor is the same regardless if you want the size of an Item or the Sequence, e.g. >>> seqs = pyseq.getSequences(".")
>>> seqs[2].size
85825547
>>> seqs[2][1].size
121976I've already made this change locally and will push it to main if you (hopefully) agree. I'm also wondering what the value of the EDIT: apologies to Johannes |
seq.size and seq.mtime are a properties now removed run from reIndex
|
Hey Ryan, all good, I made the changes too... cheers |
|
merged in 8abcd10 |
Hi Ryan,
cleaned my fork to be able to get these in
-- added mtime and size properties to item
-- added methods to sequence to get max mtime and size for the sequence object
-- added reindex function can change padding too
Regarding the s3d stuff I need to clean that and get the latest changes in my s3dbranch
Cheers
Johannes