This repository has been archived by the owner on Jan 6, 2025. It is now read-only.
Ci gem caching #101
Merged
Ci gem caching #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 3, 2020 10:46
Adding cache for Gemfile
alebanzas
added
the
do NOT merge
added 2 commits
January 3, 2020 11:39
ci: Fixing cache keys
bguiz
force-pushed
the
ci-gem-caching
branch
23 times, most recently
from
f9261a5 to
c9c9ec7
Compare
bguiz
force-pushed
the
ci-gem-caching
branch
9 times, most recently
from
6ac94fc to
f7657cd
Compare
bguiz
force-pushed
the
ci-gem-caching
branch
2 times, most recently
from
223d401 to
e1b54ca
Compare
bguiz
added
ready for review
bguiz
requested review from
a team,
solangegueiros and
alebanzas
and removed request for
a team
bguiz
reviewed
Jan 4, 2020
| @@ -0,0 +1,280 @@ | |||
| GEM | |||
There was a problem hiding this comment.
Note: Gemfile.lock was previously .gitignore'd, but now we're committing it.
Rationale: CI is using the hash of the Gemfile to determine cache equivalency, and therefore when to save and restore
| - run: | ||
| name: Set up bundle gems | ||
| command: | | ||
| bundle check || bundle install --jobs=4 --retry=3 |
There was a problem hiding this comment.
Note: The || bash operator here means that if bundle check passes, we skip bundle install. The check will pass when all available dependencies are already installed, which should happen when a cache is restored successfully.
There was a problem hiding this comment.
Reviewed/Approved. Please go ahead and merge this PR.
bguiz
approved these changes
Jan 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
bundle, based on hash ofGemfile.lockWhy
Refs