estimation-no-signature (#168)

* refactor: boltz smart wallet initialize

* chore: clarify why we check against to before calling it

* chore: update package version

---------

Co-authored-by: Antonio <antonio@iovlabs.org>

contracts/factory/BoltzSmartWalletFactory.sol

@@ -80,8 +80,6 @@ contract BoltzSmartWalletFactory is
  _nonces[req.from]++;
 
  //c07adbdc => initialize(address owner,address tokenContract,address feesReceiver,uint256 tokenAmount,uint256 tokenGas,address to,uint256 value,bytes calldata data)
- //a9059cbb = transfer(address _to, uint256 _value) public returns (bool success)
- /* solhint-disable avoid-tx-origin */
  _deploy(
  getCreationBytecode(),
  keccak256(

contracts/factory/MinimalBoltzSmartWalletFactory.sol

@@ -38,7 +38,6 @@ contract MinimalBoltzSmartWalletFactory is
  _nonces[req.from]++;
 
  // 3d326736 => initialize(address owner,address feesReceiver,uint256 tokenAmount,uint256 tokenGas,address to,bytes calldata data)
- /* solhint-disable avoid-tx-origin */
  _deploy(
  getCreationBytecode(),
  keccak256(

contracts/factory/SmartWalletFactory.sol

@@ -77,7 +77,6 @@ contract SmartWalletFactory is
  _nonces[req.from]++;
 
  //a6b63eb8 => initialize(address owner,address tokenAddr,address tokenRecipient,uint256 tokenAmount,uint256 tokenGas)
- /* solhint-disable avoid-tx-origin */
  _deploy(
  getCreationBytecode(),
  keccak256(

contracts/smartwallet/BoltzSmartWallet.sol

@@ -92,11 +92,16 @@ contract BoltzSmartWallet is BaseSmartWallet {
 
  _setOwner(owner);
 
- (bool success, bytes memory ret) = to.call{value: value}(data);
- if (!success) {
- if (ret.length == 0) revert("Unable to execute");
- assembly {
- revert(add(ret, 32), mload(ret))
+ bool success;
+ bytes memory ret;
+ // Although this check isn't strictly necessary, it's included to improve the transaction estimation
+ if (to != address(0)) {
+ (success, ret) = to.call{value: value}(data);
+ if (!success) {
+ if (ret.length == 0) revert("Unable to execute");
+ assembly {
+ revert(add(ret, 32), mload(ret))
+ }
  }
  }
 

package.json

@@ -1,6 +1,6 @@
 {
  "name": "@rsksmart/rif-relay-contracts",
- "version": "2.1.1-beta.0",
+ "version": "2.1.1-beta.1",
  "private": false,
  "description": "This project contains all the contracts needed for the rif relay system.",
  "license": "MIT",