refactor(task/withdraw): wait for transaction receipt (#147)

* refactor(task/withdraw): wait for transaction receipt

* chore: print transaction hash before waiting

---------

Co-authored-by: Antonio Morrone <antonio@iovlabs.org>

tasks/withdraw.ts

@@ -84,9 +84,12 @@ export const withdraw = async (
  );
 
  try {
- tokenAddress
+ const transaction = tokenAddress
  ? await collector.withdrawToken(tokenAddress, { gasLimit })
  : await collector.withdraw({ gasLimit });
+
+ console.log(`Waiting for transaction ${transaction.hash}...`);
+ await transaction.wait();
  } catch (error) {
  console.error(
  `Error withdrawing funds from collector with address ${collectorAddress}: ${

test/tasks/withdraw.test.ts

@@ -1,6 +1,6 @@
 import { expect, use } from 'chai';
 import chaiAsPromised from 'chai-as-promised';
-import { BigNumber, Contract, Wallet } from 'ethers';
+import { BigNumber, Contract, ContractTransaction, Wallet } from 'ethers';
 import * as hre from 'hardhat';
 import { ethers } from 'hardhat';
 import {
@@ -36,14 +36,18 @@ describe('Withdraw Script', function () {
  let stubbedCollector: SinonStubbedInstance<Contract>;
  let withdrawSpy: SinonSpy;
  let withdrawTokenSpy: SinonSpy;
+ let stubbedContractTransaction: SinonStubbedInstance<ContractTransaction>;
 
  beforeEach(function () {
+ stubbedContractTransaction = {
+ wait: sinon.stub(),
+ } as typeof stubbedContractTransaction;
  stubbedERC20 = sinon.createStubInstance(Contract);
  stubbedERC20['balanceOf'] = () => BigNumber.from(300000000);
 
  stubbedCollector = sinon.createStubInstance(Contract);
- stubbedCollector['withdraw'] = () => undefined;
- stubbedCollector['withdrawToken'] = () => undefined;
+ stubbedCollector['withdraw'] = () => stubbedContractTransaction;
+ stubbedCollector['withdrawToken'] = () => stubbedContractTransaction;
  stubbedCollector['getPartners'] = () => PARTNERS_CONFIG;
  stubbedCollector['getTokens'] = () => ALLOWED_TOKENS;