Adds RSKIP123 check to addFederatorPublicKey #2671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
use-ADD_MULTI-for-voteFederationChange-tests
to
federation-support-refactor-integration
August 5, 2024 19:52
marcos-iov
previously approved these changes
Aug 5, 2024
marcos-iov
force-pushed
the
add-rskip123-check-to-addFederatorPublicKey-0
branch
from
7a19cec
to
410acd8
Compare
nathanieliov
previously approved these changes
Aug 7, 2024
marcos-iov
force-pushed
the
federation-support-refactor-integration
branch
from
04e7eec
to
2a832e7
Compare
Base automatically changed from
federation-support-refactor-integration
to
master
August 9, 2024 15:49
marcos-iov
dismissed stale reviews from nathanieliov and themself
The base branch was changed.
marcos-iov
force-pushed
the
add-rskip123-check-to-addFederatorPublicKey-0
branch
from
410acd8
to
b74bf52
Compare
marcos-iov
force-pushed
the
add-rskip123-check-to-addFederatorPublicKey-0
branch
from
b74bf52
to
cd75f52
Compare
marcos-iov
changed the base branch from
master
to
feature/powpeg_validation_protocol
marcos-iov
changed the base branch from
feature/powpeg_validation_protocol
to
master
marcos-iov
previously approved these changes
Aug 16, 2024
|
pipeline:run |
|
|
pipeline:run |
marcos-iov
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the Bridge::addFederatorPublicKey method is disabled from the BridgeMethods class post RSKIP123.
Check this line:
rskj/rskj-core/src/main/java/co/rsk/peg/BridgeMethods.java
Line 45 in 859b52a
It still can be called directly from the FederationSupportImpl class.
We need to add a check in FederationSupportImpl to throw an exception if the “add” function is called.
This pr addresses that.