Make updateSvpState private. Call it from updateCollections #2840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
julia-zack
force-pushed
the
update_svp_state_from_uc
branch
from
972acb3 to
efabbb1
Compare
apancorb
approved these changes
Nov 8, 2024
| @@ -129,6 +130,10 @@ void setUp() { | |||
| logs | |||
| ); | |||
|
|
|||
| ECKey key = RskTestUtils.getEcKeyFromSeed("key"); | |||
| RskAddress address = new RskAddress(key.getAddress()); | |||
| when(rskTx.getSender(any())).thenReturn(address); // to not throw when calling update collections | |||
There was a problem hiding this comment.
Should we explicitly say what this param should be?
julia-zack
force-pushed
the
update_svp_state_from_uc
branch
from
efabbb1 to
99bdde2
Compare
|
nathanieliov
approved these changes
Nov 8, 2024
marcos-iov
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call
updateSvpStatefromupdateCollections.Make
updateSvpStateprivate and adapt tests.