Handling transaction revert in eth_estimateGas

[rmoreliovlabs]

Align eth_estimateGas behavior with Geth for reverted transactions

Description

This PR refactors the eth_estimateGas RPC call on RSK to handle reverted transactions similarly to Geth. Previously, the eth_estimateGas call on RSK did not return an error when a transaction was reverted. This change adds a missing check to ensure that when a transaction is reverted, the eth_estimateGas call returns an error, aligning with Geth’s behavior. Check this documentation for more info: https://www.notion.so/iovlabs/Analysis-of-eth_estimateGas-Behavior-on-RSKJ-Node-for-Reverted-Transactions-13cc132873f980c0aa87de78ed0f84a0

Motivation and Context

How Has This Been Tested?

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• Tests for the changes have been added (for bug fixes / features)
• Requires Activation Code (Hard Fork)

• Other information:

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details

Scanned Manifest Files

[fmacleal]

Good job! It was indeed a tricky issue to find. My suggestion would be to add a test to validate this revert. You could use the contract you created to debug. If you add it, it would be awesome. 🙂

[fmacleal]

LGTM. Good job.

[sonarcloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud