Improve dapp browser

[jessgusclark]

Improvements to the rWallet Dapp Browser.

• Removes internal checksums. Case: dapp submits a lowercase address and wallet was converting to checksummed version for some reason.
• Allows signing of strings, not just hex values.
• Show wallet name above address when choosing which account to use.
• Adds isRWallet flag to the web3 provider. Resolves Add isRwallet flag in the dapp injectedProvider to identify itself. #643
• Adds scrollable view when signing messages if the message is too large. Will be used in the future, when creating presentations from the RIF Id Manager. Resolves Signing a large string with wallet connect hides the signing buttons #635
• Fixes response type when sending provider.request from a dapp.

sendAsync !== request

Let's talk about this code:

window.ethereum.request = (payload) =>
  new Promise((resolve, reject) =>
    sendAsync(payload).then(response =>
      response.result
        ? resolve(response.result)
        : reject(new Error(response.message || 'provider error'))));

It replaces:

window.ethereum.request = sendAsync;

send and sendAsync both return a JSON RPC object which was handled correctly. However request should return just the value. With the previous code, it returned the RPC object, which was causing errors with newer web3 connectors, such as rlogin.

According to EIP 1193 send and sendAsync are deprecated in favor of request.

This also checks if the response.result is undefined, if it is, it rejects the promise. This is a hacky way to handle the error described in #655.

To Test

I have been using the rLogin Sample App for testing basic functionality.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[itofarina]

LGTM - tested on iOS simulator.
Thanks @jessgusclark for such a clear description!