Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

chore: update android target SDK to 30 #689

Merged
merged 4 commits into from
May 21, 2021
Merged

Conversation

patogallaiovlabs
Copy link
Collaborator

@patogallaiovlabs patogallaiovlabs commented May 19, 2021

Description

  • Change the Android API target SDK from 29 to 30.
  • Remove Google API key from repo (iOS).
  • Minor code style to iOS Firebase config.

Motivation and Context

Play Store message:

New Android App Bundle and target API level requirements in 2021
Mar 22, 2021 21:00

Starting August 2021, new apps will be required to target API level 30 (Android 11) and use the Android App Bundle publishing format. Starting November 2021, all app updates will be required to target API level 30 (Android 11). Apps with a download size of more than 150 MB are now supported by Play Asset Delivery and Play Feature Delivery.

How Has This Been Tested?

Building and running the app, doing some basic navigation and some basic transactions.

Types of changes

  • fix: bug fixes, e.g. fix Button color on DarkTheme.
  • feat: new features, e.g. add Snackbar component.
  • refactor: code refactor, e.g. new folder structure for components.
  • docs: changes into documentation, e.g. add usage example for Button.
  • test: adding or updating tests, eg unit, snapshot testing.
  • chore: tooling changes, e.g. change circleci config.
  • BREAKING CHANGE: for changes that break existing usage, e.g. change API of a component.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Other information:
    We remove the error when Android SDK 11:

Note: When syncing project with gradle files using Android SKD 11, it throws the following error:

No variants found for ':@imstar15_react-native-firebase'. Check build files to ensure at least one variant exists. at:

@patogallaiovlabs patogallaiovlabs self-assigned this May 19, 2021
@patogallaiovlabs patogallaiovlabs changed the title chore: update react-native version from 0.59.x to 0.64.x, and upgrade… chore: update react-native version from 0.59.x to 0.64.x May 19, 2021
@patogallaiovlabs patogallaiovlabs changed the title chore: update react-native version from 0.59.x to 0.64.x chore: update android target SDK to 30 May 19, 2021
author Patricio <patricio@iovlabs.org> 1621431019 -0300
committer Patricio <patricio@iovlabs.org> 1621434365 -0300

chore: upgrade android target SDK to 30
@patogallaiovlabs patogallaiovlabs added this to the v1.4.4 milestone May 19, 2021
@patogallaiovlabs patogallaiovlabs marked this pull request as ready for review May 19, 2021 18:32
Copy link
Contributor

@martinmedina martinmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@patogallaiovlabs patogallaiovlabs merged commit 5b14857 into master May 21, 2021
@patogallaiovlabs patogallaiovlabs deleted the upgrade_dependencies branch May 21, 2021 16:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants