Skip to content
This repository has been archived by the owner on Oct 2, 2023. It is now read-only.

build with parameters not work #23

Open
ko-suga opened this issue Oct 11, 2018 · 2 comments
Open

build with parameters not work #23

ko-suga opened this issue Oct 11, 2018 · 2 comments
Assignees

Comments

@ko-suga
Copy link

ko-suga commented Oct 11, 2018

734: robot.respond /j(?:enkins)? build (.*)(, (.+))?/i, id: 'jenkins.build', (msg) ->

It could not extract params. It use "job, foo=bar" as job name, and job not found.

@zack-hable zack-hable self-assigned this Nov 14, 2018
@zack-hable
Copy link
Contributor

hey @ko-suga I'll try to see if I can replicate this issue sometime this week and possibly issue a fix.

@zack-hable
Copy link
Contributor

@ko-suga I believe I have resolved the issue and think it may be best to switch the delimiter between the job name and parameters to a "&" symbol as jenkins jobs could have a "," in them. You can apply the changes from this branch until we get this approved/merged into master.

arykalin added a commit to arykalin/docker-slack-hubot that referenced this issue Apr 22, 2019
arykalin added a commit to arykalin/docker-slack-hubot that referenced this issue Apr 22, 2019
arykalin added a commit to arykalin/docker-slack-hubot that referenced this issue Apr 22, 2019
arykalin added a commit to arykalin/docker-slack-hubot that referenced this issue Apr 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants