Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'Version ' to nameID 5 version string, per MS OT spec #140

Merged
merged 1 commit into from
Mar 27, 2019

Conversation

thundernixon
Copy link
Contributor

Inter's nameID 5 formatting was been improved by 20aaab6, but still fails FontBakery check 055:

🔥FAIL: Version format is correct in 'name' table?
  • com.google.fonts/check/055
  • 🔥FAIL The NameID.VERSION_STRING (nameID=5) value must follow the pattern "Version X.Y" with X.Y between 1.000 and 9.999. Current version string is: "3.4;6e0206421" [code: bad-version-strings]

According to the Microsoft OpenType spec for nameID 5:

Version string. Should begin with the syntax “Version .” (upper case, lower case, or mixed, with a space between “Version” and the number).

This PR is a small change that makes that happen, allowing Inter to successfully pass check 055.

@rsms
Copy link
Owner

rsms commented Mar 27, 2019

Yikes. This is pretty messed up I think, that the text "Version " needs to appear in the value for the field "version". Oh well, we live with the mistakes of the people who came before us I suppose :–)

@rsms rsms merged commit 3488601 into rsms:master Mar 27, 2019
@thundernixon
Copy link
Contributor Author

pretty messed up that the text "Version " needs to appear in the value for the field "version"

😄 Haha, yeah, it doesn't really make the most sense, but these are the kinds of things that get frozen into things once they're implemented in a bunch of software. Thanks for the merge!

@thundernixon thundernixon deleted the version-string-format branch March 27, 2019 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants