Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CMakeLists.txt instead of a custom Makefile #1

Open
devnoname120 opened this issue Jan 25, 2018 · 0 comments
Open

Use CMakeLists.txt instead of a custom Makefile #1

devnoname120 opened this issue Jan 25, 2018 · 0 comments

Comments

@devnoname120
Copy link

devnoname120 commented Jan 25, 2018 •
edited
Loading

For some reason this library is compiled using a Makefile.vita file. There are side effects to this such as sdl2.pc not being created: https://github.com/rsn8887/SDL-Vita/blob/master/CMakeLists.txt#L1639

This is an issue for programs such as OpenRCT2 that use pkgconfig to find libraries.
rsn8887 added a commit that referenced this issue Apr 28, 2018
@rsn8887 @Rinnegatamante
Fix sharp_* shaders, fix formatting in other shaders (#1)
32dc6b2
sergiou87 pushed a commit to sergiou87/SDL-Vita that referenced this issue Jun 3, 2020
@1bsyl
Android: revert previous commit (Bug 4669)
ba509cc 
(Refs rsn8887#1)
sergiou87 pushed a commit to sergiou87/SDL-Vita that referenced this issue Jun 3, 2020
@1bsyl
Android: prevents rare crashes when app goes to background or ends.
a87e8ff 
Make sure the thread is actually paused, and context backep-up, before
SurfaceView is destroyed (eg surfaceDestroyed() actually returns).

Add a timeout when surfaceDestroyed() is called, and check 'backup_done' variable.

It prevents crashes like:

  #00  pc 000000000000c0d0  /system/lib64/libutils.so (android::RefBase::incStrong(void const*) const+8)
  rsn8887#1  pc 000000000000c7f4  /vendor/lib64/egl/eglSubDriverAndroid.so (EglAndroidWindowSurface::UpdateBufferList(ANativeWindowBuffer*)+284)
  rsn8887#2  pc 000000000000c390  /vendor/lib64/egl/eglSubDriverAndroid.so (EglAndroidWindowSurface::DequeueBuffer()+240)
  rsn8887#3  pc 000000000000bb10  /vendor/lib64/egl/eglSubDriverAndroid.so (EglAndroidWindowSurface::GetBuffer(EglSubResource*, EglMemoryDesc*)+64)
  rsn8887#4  pc 000000000032732c  /vendor/lib64/egl/libGLESv2_adreno.so (EglWindowSurface::UpdateResource(EsxContext*)+116)
  rsn8887#5  pc 0000000000326dd0  /vendor/lib64/egl/libGLESv2_adreno.so (EglWindowSurface::GetResource(EsxContext*, EsxResource**, EsxResource**, int)+56)
  rsn8887#6  pc 00000000002ae484  /vendor/lib64/egl/libGLESv2_adreno.so (EsxContext::AcquireBackBuffer(int)+364)
  rsn8887#7  pc 0000000000249680  /vendor/lib64/egl/libGLESv2_adreno.so (EsxContext::Clear(unsigned int, unsigned int, unsigned int, EsxClearValues*)+1800)
  rsn8887#8  pc 00000000002cb52c  /vendor/lib64/egl/libGLESv2_adreno.so (EsxGlApiParamValidate::GlClear(EsxDispatch*, unsigned int)+132)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@devnoname120