Skip to content

Travis Build #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
May 18, 2016
Merged

Travis Build #40

2 commits merged into from
May 18, 2016

Conversation

benjchristensen
Copy link
Contributor

Continuous builds on Travis CI

@benjchristensen
Copy link
Contributor Author

Note that I have not yet tested whether it correctly shows as "failed" if a unit test fails. I'm assuming ./ReactiveSocketTest will return a value other than 0 and thus fail the build.

@ghost
Copy link

ghost commented May 18, 2016

Yep, I believe it to be the case.

Could you update make command to make -j8 or something? It seems that build is slow because of that.

@benjchristensen
Copy link
Contributor Author

This pull request successfully shows how Travis does the build and shows as "green". The log can be seen here: https://travis-ci.org/ReactiveSocket/reactivesocket-cpp/builds/131003661

@benjchristensen
Copy link
Contributor Author

men4a

Yak shaved.

@ghost
Copy link

ghost commented May 18, 2016

Great!

@ghost ghost merged commit f88b352 into rsocket:master May 18, 2016
@benjchristensen
Copy link
Contributor Author

Build time with make: 1 minutes 43 seconds
Build time with make -j8: 1 minute 42 seconds
Build time without precompiled folly: > 10 minutes

@benjchristensen benjchristensen deleted the travis-build branch May 18, 2016 00:28
@ghost
Copy link

ghost commented May 18, 2016

#12 will speed things up, assuming we actually have multiple cores to build (I don't know how big the container is).

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant