Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup build logic #252

Merged
merged 2 commits into from
May 13, 2024
Merged

Cleanup build logic #252

merged 2 commits into from
May 13, 2024

Conversation

whyoleg
Copy link
Member

@whyoleg whyoleg commented Mar 2, 2024

Overall, the idea is that latest Gradle/KGP versions and suggesting allowed to cleanup some code.

Just build-related changes:

  • align build-logic naming with what Gradle suggests
    • move build-logic to root of the project
  • introduce build-logic-settings
  • remove build-parameters
  • move kotlin version to Version Catalog
  • extract Gradle related versions to Version Catalog
  • drop target-specific convention plugins, as KGP now generates accessors
  • use targets helpers in projects instead of convention plugins
  • drop template convention plugins, leave only library - inline other usages

Code/functionality related changes:

  • run tests on JDK 21
  • minor cleanup in the publication script
  • create test aggregate tasks (to run by CI)
  • reduce usages of OptIns
  • use jvm-default=all (easier compatibility in future)
  • drop test server completely for now from rsocket-transport-tests

@whyoleg whyoleg requested a review from OlegDokuka March 2, 2024 08:38
@whyoleg whyoleg self-assigned this Mar 2, 2024
Copy link

github-actions bot commented Mar 2, 2024

Test Results

  699 files  ±0    699 suites  ±0   37m 7s ⏱️ -1s
2 179 tests ±0  1 950 ✅ ±0  229 💤 ±0  0 ❌ ±0 
4 562 runs  ±0  4 032 ✅ ±0  530 💤 ±0  0 ❌ ±0 

Results for commit d5c1b35. ± Comparison against base commit 2239c5c.

This pull request removes 201 and adds 201 tests. Note that renamed tests count towards both.
io.rsocket.kotlin.ConnectionEstablishmentTest ‑ requesterReleaseSetupPayloadOnFailedAcceptor[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.ConnectionEstablishmentTest ‑ responderRejectSetup[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldFailBelowLowerBond[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldFailOverUpperBond[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldSuccessfullyCreateAtLowerBond[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldSuccessfullyCreateAtUpperBond[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldSuccessfullyCreateNearLowerBond[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldSuccessfullyCreateNearUpperBond[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldSuccessfullyCreate[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.core.RSocketTest ‑ requestChannelCancellationFromResponderShouldLeaveStreamInHalfClosedStateWithNextCompletionPossibleFromRequester[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
…
io.rsocket.kotlin.ConnectionEstablishmentTest ‑ requesterReleaseSetupPayloadOnFailedAcceptor[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
io.rsocket.kotlin.ConnectionEstablishmentTest ‑ responderRejectSetup[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldFailBelowLowerBond[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldFailOverUpperBond[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldSuccessfullyCreateAtLowerBond[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldSuccessfullyCreateAtUpperBond[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldSuccessfullyCreateNearLowerBond[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldSuccessfullyCreateNearUpperBond[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldSuccessfullyCreate[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
io.rsocket.kotlin.core.RSocketTest ‑ requestChannelCancellationFromResponderShouldLeaveStreamInHalfClosedStateWithNextCompletionPossibleFromRequester[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
…
This pull request removes 9 skipped tests and adds 9 skipped tests. Note that renamed tests count towards both.
io.rsocket.kotlin.ConnectionEstablishmentTest ‑ responderRejectSetup[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestChannel16x256[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestChannel200000[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestChannel20000[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestChannel256x512[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestChannel500NoLeak[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestResponse100000[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestResponse10000[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestStream500NoLeak[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.ConnectionEstablishmentTest ‑ responderRejectSetup[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestChannel16x256[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestChannel200000[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestChannel20000[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestChannel256x512[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestChannel500NoLeak[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestResponse100000[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestResponse10000[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestStream500NoLeak[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]

♻️ This comment has been updated with latest results.

@whyoleg whyoleg force-pushed the build-logic branch 2 times, most recently from adb59a1 to ec8442c Compare April 15, 2024 19:45
* align build-logic plugins with Gradle suggestions;
* introduce build-logic-settings for multiple settings configuration;
* move kotlin version to Version Catalog;
* move build-logic to root of the project;
* remove build-parameters;
* rename build-logic plugins;
* minor cleanup in the publication script;
* drop target-specific convention plugins, as KGP now generates; accessors;
* use targets helpers in projects;
* drop template convention plugins;
* create test aggregate tasks;
* reduce usages of OptIns;
* use jvm-default=all (easier compatibility in future);
* drop test server completely for now from `rsocket-transport-tests`;
* Update some Gradle properties;
* implement small DSL for including projects;
@whyoleg whyoleg merged commit 0e891e6 into master May 13, 2024
27 checks passed
@whyoleg whyoleg deleted the build-logic branch May 13, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants