Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename and refactor ktor plugins #258

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Rename and refactor ktor plugins #258

merged 1 commit into from
Oct 21, 2024

Conversation

whyoleg
Copy link
Member

@whyoleg whyoleg commented Apr 16, 2024

  • ktor plugins migrated to use new/actual plugins API
  • changes are mostly source compatible (not ABI compatible)
  • new artefact names ktor-client-rsocket instead of rsocket-ktor-client (same for server)
    • motivation is to make it more aligned with ktor (f.e with ktor-client-websockets) and to better distinguish from standalone transport modules like rsocket-transport-ktor-websocket-client
  • artefacts with old coordinates kept for compatibility and will be removed in future release

@whyoleg whyoleg requested a review from OlegDokuka April 16, 2024 17:38
@whyoleg whyoleg self-assigned this Apr 16, 2024
Copy link

github-actions bot commented Apr 16, 2024

Test Results

  502 files  ±0    502 suites  ±0   44m 34s ⏱️ -50s
2 185 tests ±0  1 830 ✅ +3  351 💤 ±0   4 ❌  - 3 
5 048 runs  ±0  4 166 ✅ +2  870 💤 ±0  12 ❌  - 2 

For more details on these failures, see this check.

Results for commit dff5d82. ± Comparison against base commit e9f1ff8.

♻️ This comment has been updated with latest results.

@whyoleg whyoleg merged commit 780ef3e into master Oct 21, 2024
3 checks passed
@whyoleg whyoleg deleted the ktor-plugins branch October 21, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant