Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update formatter and use random port #2

Merged
merged 1 commit into from
Jul 12, 2024
Merged

build: update formatter and use random port #2

merged 1 commit into from
Jul 12, 2024

Conversation

fi3ework
Copy link
Member

  • Use biome to format CSS as well (default false), turn whitespace to space
  • Use random port helper

chenjiahan
chenjiahan approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chenjiahan chenjiahan merged commit b615ccc into rspack-contrib:main Jul 12, 2024
1 check passed
@fi3ework fi3ework deleted the port branch July 12, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fi3ework @chenjiahan