Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActiveSupport not loading properly/completely #21

Open
grantneufeld opened this issue Dec 30, 2014 · 3 comments
Open

ActiveSupport not loading properly/completely #21

grantneufeld opened this issue Dec 30, 2014 · 3 comments
Assignees
@seuros

Comments

@grantneufeld
Copy link
Contributor

Running with ruby 2.2.0, rails 4.2.0, rspec-rails 3.1.0 (rspec-core 3.1.7), rspec-autotest 1.0.0.

On running autotest, this produces an uninitialized constant ActiveSupport::Deprecation error. active_support/deprecation is not being loaded. The stack trace is showing this hitting at lib/rspec/rails/autotest.rb:26.

When I replaced the line (26):

require 'active_support/core_ext'

with:

require 'active_support/all'

I was able to run my full test suite without any problems.
grantneufeld added a commit to grantneufeld/rspec-autotest that referenced this issue Dec 30, 2014
@grantneufeld
Update autotest.rb
4d0ce08 
Running with Ruby 2.2.0, Rails 4.2.0, Rspec-Rails 3.1.0 (rspec-core 3.1.7), produces an `uninitialized constant ActiveSupport::Deprecation` error because the `active_support/deprecation` is not being loaded.

This addresses issue rspec#21
@grantneufeld grantneufeld mentioned this issue Dec 30, 2014
Merged
grantneufeld added a commit to grantneufeld/rspec-autotest that referenced this issue Dec 30, 2014
@grantneufeld
Update autotest.rb
adc777d 
Fix for rspec#21
@timharding
Copy link

+1

Stack here:

https://gist.github.com/timharding/40433fd3a8a81361a444

Can confirm that the patch above solves for me.

@seuros seuros self-assigned this Jan 21, 2015
ochaochaocha3 added a commit to cre-ne-jp/rgrb that referenced this issue Mar 7, 2015
@ochaochaocha3
UrlFetchTitle: 非 HTML ファイルの情報表示を実装した
5759ff1 
refs #5

* 非 HTML ファイルでは Content-Type と Content-Length
    を返信に含めるようにした
* テスト時に ActiveSupport の読み込みでエラーが起きないよう
    spec_helper.rb で activesupport/all を読み込むようにした
    rspec/rspec-autotest#21 を参照
@kristjan
Copy link

Any plans to release a new version with this fix? Are there issues with Rails 3 compatibility?

@JonRowe
Copy link
Member

JonRowe commented Jun 16, 2015

I believe it's just necessary to find the deprecations so this part of active support isn't needed, or add just the deprecations library, we certainly don't want all included here, PRs are accepted but I don't have the bandwidth to work on this myself currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seuros seuros

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@timharding @grantneufeld @kristjan @JonRowe @seuros