Merge pull request #967 from rspec/quick_fix_for_deprecation_formatte…

…r_on_jruby

Properly base #966 off 2-14-maintenance

Changelog.md

@@ -1,3 +1,9 @@
+#dev
+
+Bug fix
+* Implement `#start` on the Deprecation Formatter to prevent collision with
+  `ruby-debug` on JRuby (Alex Portnov, Jon Rowe)
+
 ### 2.14.0 / 2013-07-06
 [full changelog](http://github.com/rspec/rspec-core/compare/v2.14.0.rc1...v2.14.0)
 

lib/rspec/core/reporter.rb

@@ -21,7 +21,7 @@ def initialize(*formatters)
     # events to all registered listeners
     def register_listener(listener, *notifications)
       notifications.each do |notification|
-        @listeners[notification.to_sym] << listener if listener.respond_to?(notification)
+        @listeners[notification.to_sym] << listener if understands(listener, notification)
       end
       true
     end
@@ -127,5 +127,19 @@ def notify(event, *args, &block)
         formatter.send(event, *args, &block)
       end
     end
+
+    private
+      if Method.method_defined?(:owner) # 1.8.6 lacks Method#owner
+        def understands(listener, notification)
+          listener.respond_to?(notification) && listener.method(notification).owner != ::Kernel
+        end
+      else
+        def understands(listener, notification)
+          # Hack for 1.8.6
+          # {}.method(:=~).to_s # => "#<Method: Hash(Kernel)#=~>"
+          listener.respond_to?(notification) && !listener.method(notification).to_s.include('(Kernel)')
+        end
+      end
+
   end
 end

spec/rspec/core/formatters/deprecation_formatter_spec.rb

@@ -4,6 +4,7 @@
 
 module RSpec::Core::Formatters
   describe DeprecationFormatter do
+
     describe "#deprecation" do
       let(:deprecation_stream) { StringIO.new }
       let(:summary_stream)     { StringIO.new }

spec/rspec/core/reporter_spec.rb

@@ -9,7 +9,7 @@ module RSpec::Core
 
       %w[start_dump dump_pending dump_failures dump_summary close].each do |message|
         it "sends #{message} to the formatter(s) that respond to message" do
-          formatter.as_null_object.should_receive(message)
+          formatter.should_receive(message)
           reporter.abort(nil)
         end
 
@@ -34,7 +34,7 @@ module RSpec::Core
       it "passes example_group_started and example_group_finished messages to that formatter in that order" do
         order = []
 
-        formatter = double("formatter").as_null_object
+        formatter = double("formatter")
         formatter.stub(:example_group_started) { |group| order << "Started: #{group.description}" }
         formatter.stub(:example_group_finished) { |group| order << "Finished: #{group.description}" }
 
@@ -61,7 +61,7 @@ module RSpec::Core
 
     context "given an example group with no examples" do
       it "does not pass example_group_started or example_group_finished to formatter" do
-        formatter = double("formatter").as_null_object
+        formatter = double("formatter")
         formatter.should_not_receive(:example_group_started)
         formatter.should_not_receive(:example_group_finished)
 
@@ -120,18 +120,41 @@ module RSpec::Core
       end
     end
 
+    describe 'when message implemented on kernel' do
+      def with_message_defined_on_kernel
+        return yield if ::Kernel.method_defined?(:start)
+
+        begin
+          ::Kernel.module_eval { def start(*); raise "boom"; end }
+          yield
+        ensure
+          ::Kernel.module_eval { undef start }
+        end
+      end
+
+      let(:formatter) { double("formatter") }
+
+      it 'does not blow up when `Kernel` defines message instead of a formatter' do
+        with_message_defined_on_kernel do
+          reporter = ::RSpec::Core::Reporter.new(formatter)
+          reporter.start(3)
+        end
+      end
+    end
+
     describe "timing" do
       it "uses RSpec::Core::Time as to not be affected by changes to time in examples" do
-        formatter = double(:formatter).as_null_object
-        reporter = Reporter.new formatter
-        reporter.start 1
-        Time.stub(:now => ::Time.utc(2012, 10, 1))
-
+        formatter = double(:formatter)
         duration = nil
         formatter.stub(:dump_summary) do |dur, _, _, _|
           duration = dur
         end
 
+        reporter = Reporter.new formatter
+        reporter.start 1
+        Time.stub(:now => ::Time.utc(2012, 10, 1))
+
+
         reporter.finish 1234
         expect(duration).to be < 0.2
       end