Skip to content
This repository has been archived by the owner on Nov 30, 2024. It is now read-only.

Commit

Permalink
Support rake 11.x
Browse files Browse the repository at this point in the history 
The method `Rake.application.last_comment` has been removed
in favor of `Rake.application.last_description`
  • Loading branch information
@tjgrathwell
tjgrathwell committed Mar 9, 2016
1 parent 910b3d9 commit 8e723fc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/rspec/core/rake_task.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def run_task(verbose)

# @private
def define(args, &task_block)
desc "Run RSpec code examples" unless ::Rake.application.last_comment
desc "Run RSpec code examples" unless ::Rake.application.last_description

task name, *args do |_, task_args|
RakeFileUtils.__send__(:verbose, verbose) do
Expand Down

9 comments on commit 8e723fc

@psantos10
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When this change will be released as a gem? I am having trouble with my application after update Rails and Rake

@yujinakayama
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll cut a patch release soon.

@psantos10
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@damianlegawiec
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Mafi88
Copy link

@Mafi88 Mafi88 commented on 8e723fc Mar 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@carlesjove
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To anyone running into this issue, here's a tmp workaround: http://stackoverflow.com/a/35893941/1876328 :-)

@cdenneen
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlesjove I tried this and it didn't seem to work. 👍 waiting on new release

@psantos10
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlesjove and @cdenneen , I think that the new version os working now.
Use this version: https://rubygems.org/gems/rspec-core/versions/3.4.4

@yujinakayama
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This committed is already merged and released as rspec-core 3.4.4. See #2197.

Please sign in to comment.