This repository has been archived by the owner on Nov 30, 2024. It is now read-only.
Use configuration rather than streams directly in deprecation formatter and fall back to std pipes #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good except for the failing build. Let me know if you want help with that. |
|
@myronmarston done |
|
or maybe not... |
|
Thanks Jon...merging since it's green so I can work off this for my PR. |
myronmarston
added a commit
that referenced
this pull request
Nov 2, 2013
Use configuration rather than streams directly in deprecation formatter and fall back to std pipes
|
👍 |
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…n_formatter_fix_299 Use configuration rather than streams directly in deprecation formatter and fall back to std pipes --- This commit was imported from rspec/rspec-core@c63dc74.
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…precation_formatter_fix_299" This reverts commit c63dc74b8b4b5f5f7ba89aa5405ee862130818f2, reversing changes made to 64ba91330df9e8d8cd47f7831e25f19089af4361. We're reverting this because this didn't actually solve the problem of issueing deprecation warnings from option_parser.rb. --- This commit was imported from rspec/rspec-core@fdcd136.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential solution to #1128 rebased off 2-99