Remove redundant require ostruct #3095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makicamel
force-pushed
the
remove-redundunt-require
branch
from
d6c453c
to
1121aea
Compare
JonRowe
approved these changes
Jul 7, 2024
|
Can you rebase this once #3097 is merged / or cherry-pick that commit, theres an issue with our legacy actions needing fixing. |
|
#3097 has been merged |
requiring ostruct is introduced at rspec@5cd41d3 and removed using OpenStruct at rspec@d7e4033 . ostruct was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.5.0. Related https://bugs.ruby-lang.org/issues/20309 ruby/ruby#10428
makicamel
force-pushed
the
remove-redundunt-require
branch
from
1121aea
to
47b31ad
Compare
|
@JonRowe |
JonRowe
added a commit
that referenced
this pull request
Sep 5, 2024
Remove redundant require ostruct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requiring ostruct was introduced at 5cd41d3 and removed using OpenStruct at d7e4033 .
ostruct was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.5.0.
Related https://bugs.ruby-lang.org/issues/20309 ruby/ruby#10428