This repository has been archived by the owner on Nov 30, 2024. It is now read-only.
Remove TextMateFormatter. Now use rspec-tmbundle. #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 1fb4579 on cupakromer:remove-textmate-formatter into * on rspec:master*. |
| @@ -4,6 +4,7 @@ Breaking Changes for 3.0.0: | |||
|
|
|||
| * Remove explicit support for 1.8.6 (Jon Rowe) | |||
| * Remove color aliases on BaseTextFormatter. (Sam Phippen) | |||
| * Remove TextMateFormatter use rspec-tmbundle instead. (Aaron Kromer) | |||
There was a problem hiding this comment.
@cupakromer to me this reads like a command, not an entry in a changelog. I might write something like Remove TextMateFormatter, it has been replaced by rspec-tmbundle. WDYT?
There was a problem hiding this comment.
Sounds good 👍 I'll rebase this on top.
|
@cupakromer thanks, I had a comment. Also could you rebase this on top of master ❤️. |
|
Changes Unknown when pulling b0097fc on cupakromer:remove-textmate-formatter into * on rspec:master*. |
JonRowe
added a commit
that referenced
this pull request
Jul 9, 2013
Remove TextMateFormatter. Now use rspec-tmbundle.
|
👍 |
myronmarston
added a commit
that referenced
this pull request
Jul 13, 2013
myronmarston
added a commit
that referenced
this pull request
Jul 14, 2013
Remove additional textmate stuff that was accidentally left in #962.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #758 opening a PR to remove the
TextMateFormatterfrom core, in favor of it being inrspec-tmbundle.Ref the rspec-tmbundle PR: rspec/rspec.tmbundle#50