Add deprecation warnings for features to be removed/changed in RSpec 4 #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoittgt
force-pushed
the
rspec-should-syntqx-deprecation
branch
from
377fab5
to
ed390ed
Compare
benoittgt
force-pushed
the
rspec-should-syntqx-deprecation
branch
from
c7bac85
to
46a72a3
Compare
benoittgt
commented
Jun 1, 2021
benoittgt
force-pushed
the
rspec-should-syntqx-deprecation
branch
from
c03a0cd
to
5eb1d10
Compare
|
If we clone add-major-update-deprecation-warnings from rspec/rspec-core#2880 We do not have the CI failure. I did a wip commit for the CI |
benoittgt
commented
Jun 3, 2021
| "`:should` Expectations syntax", | ||
| {:call_site=>nil, :replacement=>"the default `expect` syntax"}, | ||
| ] | ||
| expect(RSpec).to receive(:deprecate).with(*syntax_arguments).at_least(:once) |
There was a problem hiding this comment.
I need to add .at_least(:once) because of line 157 that leak into the test. If you comment it out, there is not need for .at_least(:once) anymore.
benoittgt
force-pushed
the
rspec-should-syntqx-deprecation
branch
from
9478153
to
31ca861
Compare
pirj
changed the title
pirj
force-pushed
the
rspec-should-syntqx-deprecation
branch
4 times, most recently
from
17e2bd3
to
8b709f1
Compare
pirj
force-pushed
the
rspec-should-syntqx-deprecation
branch
3 times, most recently
from
bf684ea
to
b9c9c2e
Compare
|
All three sibling PRs are green together. @JonRowe, @benoittgt please have a look. I suggest the following merge order: |
benoittgt
commented
Jul 18, 2021
lib/rspec/matchers/built_in/has.rb
Outdated
| predicate_actual = predicate_result | ||
| if value == !!predicate_actual && value != predicate_actual | ||
| RSpec.deprecate( | ||
| "`#{predicate_method_name}` returned neither `true` nor `false`, but rather `#{predicate_actual.inspect}`") |
There was a problem hiding this comment.
Good deprecation warning!
pirj
force-pushed
the
rspec-should-syntqx-deprecation
branch
2 times, most recently
from
4fd9b36
to
d67e751
Compare
pirj
force-pushed
the
rspec-should-syntqx-deprecation
branch
from
d67e751
to
800f5e4
Compare
pirj
force-pushed
the
rspec-should-syntqx-deprecation
branch
from
800f5e4
to
c75a966
Compare
|
Does it need work to make the CI green? -- |
|
It should become green when a corresponding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds deprecation warnings for the work done on unreleased RSpec 4.
fixes #1302
shouldfor configuration and usage.include_chain_clauses_in_custom_matcher_descriptionsoption #1279). Deprecation warning when usedThis is purposed to be released as version 3.99.
Sibling PRs:
Deprecation warnings list: #1302
Release strategy: rspec/rspec-core#2880 (comment)
RSpec 4 plan: https://github.com/rspec/rspec/issues/61
Changes: https://github.com/rspec/rspec-expectations/blob/4-0-dev/Changelog.md#development