-
-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for legacy RSpec matchers (pre 3) #1253
Conversation
def include_chain_clauses_in_custom_matcher_descriptions? | ||
@include_chain_clauses_in_custom_matcher_descriptions ||= false | ||
@include_chain_clauses_in_custom_matcher_descriptions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
||= true
obviously doesn't work when false
is assigned explicitly.
b330730
to
2926bc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Minor change log tweak
Some how the last change has messed up the history to include all the other changes? |
I've branched this PR off #1245, so this is as expected. History needs some commit juggling anyway. I want to spread the Changelog changes over commits. Also, the base PR was fixed up, so a rebase on it will be needed. Can't tell for sure, but I believe there might be some overlapping changes. Converted this to draft until #1245 is merged. |
ddc7545
to
db4806c
Compare
2926bc9
to
bbaef45
Compare
db4806c
to
d52d1f7
Compare
bbaef45
to
6996e4f
Compare
d52d1f7
to
fedb7ec
Compare
1ab4671
to
e8e8bfc
Compare
As per http://rspec.info/blog/2013/07/the-plan-for-rspec-3/: > compatibility layer so that existing matchers will continue to work, with the plan to remove that compatibility layer in RSpec 4
fedb7ec
to
33f07d8
Compare
…rspec/remove-deprecations Remove support for legacy RSpec matchers (pre 3) --- This commit was imported from rspec/rspec-expectations@c167e5f.
As per http://rspec.info/blog/2013/07/the-plan-for-rspec-3/:
LegacyMacherAdapter
(with typo)