Remove kw args warning from has_<n> matcher #1184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
force-pushed
the
remove-kw-args-warning-from-has-matcher
branch
from
e70629a
to
fa5788d
Compare
|
Build failures is because of nested spec runs for rspec-core not having the right dependency, if the support PR is merged and pin dropped it should be fixed. |
benoittgt
approved these changes
May 13, 2020
| @@ -65,7 +65,7 @@ def predicate_exists? | |||
| end | |||
|
|
|||
| def predicate_matches? | |||
| @actual.__send__(predicate, *@args, &@block) | |||
| RSpec::Support::WithKeywordsWhenNeeded.send_to(@actual, predicate, *@args, &@block) | |||
There was a problem hiding this comment.
That's great to have this. LGTM
pirj
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1183 Requires rspec/rspec-support#413