Factorize common DynamicPredicate base. #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
approved these changes
Jun 18, 2020
marcandre
force-pushed
the
refactor_same_output
branch
from
07fdde0
to
6eebf29
Compare
Output is kept the same temporarily
marcandre
force-pushed
the
refactor_same_output
branch
from
6eebf29
to
c028a9a
Compare
|
Rebased, just to be sure. @JonRowe could this be merged please? Two subsequent PRs are waiting on this. |
JonRowe
requested changes
Aug 27, 2020
Comment on lines
+89
to
+91
| def predicate_method_name | ||
| predicate | ||
| end |
There was a problem hiding this comment.
I feel like this should be in the Has class as this implementation is only used there? (I've checked the other PR so I think thats the case?)
There was a problem hiding this comment.
Ah actually, I see, its not used elsewhere in has, ignore this comment. Commented on the wrong comment.
JonRowe
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
has_...andbe_...dynamic predicate matchers have a lot in common.This PR refactors both in terms of a common base class.
Output is kept the same temporarily
Precursor to #1195