This repository has been archived by the owner on Nov 30, 2024. It is now read-only.
Updates from rspec-dev (2020-12-24) #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
approved these changes
Dec 24, 2020
benoittgt
deleted the
update-common-plaintext-files-2020-12-24-for-main-
branch
JonRowe
reviewed
Dec 25, 2020
| conventions on the project so that the code has stylistic consistency | ||
| throughout. Run with: | ||
| We use [Rubocop](https://github.com/bbatsov/rubocop) to enforce style conventions on the project so | ||
| that the code has stylistic consistency throughout. Run with: |
There was a problem hiding this comment.
Seems so. I remember I was fixing this, but I wasn't fully aware that BUILD_DETAIL.md is coming from rspec-dev.
pirj
reviewed
Dec 25, 2020
|
|
||
| ``` | ||
| $ bundle exec rubocop | ||
| $ bundle exec rubocop lib |
There was a problem hiding this comment.
This is the only regression worth fixing, along with a similar change in DEVELOPMENT.md.
Other changes being overwritten do not matter much.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some updates, generated from rspec-dev's rake tasks.
rspec/rspec-dev#271