This repository has been archived by the owner on Nov 30, 2024. It is now read-only.
Updates from rspec-dev (2021-07-13) #1308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return true from aggregate_failures
…6-for-main Updates from rspec-dev (2020-11-16)
…6-for-main Updates from rspec-dev (2020-11-16)
…8-for-main Updates from rspec-dev (2020-11-18)
Coverage has changed on GHA fixup cov
…2-for-main Updates from rspec-dev (2020-11-22)
…8-for-main Updates from rspec-dev (2020-12-08)
…9-for-main Updates from rspec-dev (2020-12-09)
-["include {:message => (match /legacy\\s+RSpec\\s+matcher/), :call_site => (include \"/home/runner/work/rspec-support/rspec-expectations/spec/rspec/matchers/legacy_spec.rb:31\")}"]
+[{:message=>
+ "#<#<Class:0x000055fcd6e44840>:0x000055fcd6e52bc0> implements a legacy RSpec matcher\nprotocol. For the current protocol you should expose the failure messages\nvia the `failure_message` and `failure_message_when_negated` methods.\n(Used from /home/runner/work/rspec-support/rspec-expectations/spec/rspec/matchers/legacy_spec.rb:31:in `block (4 levels) in <module:Matchers>')\n",
+ :type=>"legacy_matcher"}]
See rspec/rspec-support#452
Fix ill-defined warn expectation
…1-for-main Updates from rspec-dev (2020-12-21)
…2-for-main- Updates from rspec-dev (2020-12-22)
…0-12-25-for-main Updates from rspec-dev (2020-12-25)
…2-for-main Updates from rspec-dev (2021-01-02)
…2-for-main Updates from rspec-dev (2021-01-02)
…2-for-main Updates from rspec-dev (2021-01-02)
…2-for-main Updates from rspec-dev (2021-01-22)
…2-for-main Updates from rspec-dev (2021-01-22)
https://blog.rubystyle.guide/rspec/2019/07/17/rspec-implicit-block-syntax.html https://rspec.rubystyle.guide/#implicit-block-expectations Spec changes are due to: matcher.matches?(invalid_value) doesn't work with block-only matchers, as no block is passed in, and it fails with a message: 1) RSpec::Matchers::BuiltIn::Change behaves like an RSpec block-only matcher uses the `ObjectFormatter` for `failure_message` Failure/Error: expect(message).to include("detailed inspect") expected "expected `@k` to have changed, but was not given a block" to include "detailed inspect" The redundant (due to existing check in ExpectationTarget) `Proc === @event_proc` checks could not be removed safely as well, since @actual_after is not initialized yet when we haven't executed the block: RuntimeError: Warnings were generated: rspec-dev/repos/rspec-expectations/lib/rspec/matchers/built_in/change.rb:407: warning: instance variable @actual_after not initialized Ruby 1.8-specific workarounds: multiple values for a block parameter (0 for 1) If a block expects an argument, it ought to be provided an argument in 1.8
…with-value-expectation-target Print deprecation message when implicit block expectation syntax is used
Fix YARD type syntax
See rspec/rspec-collection_matchers#48 If a matcher supports dynamic arbitrary methods called on it, e.g. `have_at_least(100).bucks`, it would also consider a `supports_value_expectations?` call as a dynamic part. Instead of calling `supports_*?` methods on a matcher, explicitly check if it responds to it.
Fix support for dynamic matchers
…3-for-main Updates from rspec-dev (2021-04-23)
…3-for-main Updates from rspec-dev (2021-07-13)
…5-for-main Updates from rspec-dev (2021-07-15)
JonRowe
force-pushed
the
update-ci-build-scripts-2021-07-13-for-3-10-maintenance
branch
from
cd4702c to
2cc6c3a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some updates, generated from rspec-dev's rake tasks.