This repository has been archived by the owner on Nov 30, 2024. It is now read-only.
Give users an error when they use a value matcher in a block expectation expression #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @JonRowe @cupakromer |
| class ExpectationTarget | ||
| # @private | ||
| # Used as a sentinel value to be able to tell when the user |
There was a problem hiding this comment.
I've never heard the term "sentinel value" before, I like it.
|
OK, I refactored based on @JonRowe's suggestion. Still have a couple more TODOs (see above). |
|
Hmm, I'm actually wondering if RSpec::Matchers.define :match_a_block do
match { ... }
supports_block_expectations
endAlso, Any preference? |
|
I'm ok with |
|
Agree, 👍 for |
This is used to give users a clear error when they
wrongly use a value matcher against a block, expecting
it to match against the return value of the block:
expect { 3 }.to eq(3)
|
OK, I think this is ready to go (except for the 2.99 deprecation)....care to rereview? |
This was referenced Apr 19, 2014
|
LGTM |
myronmarston
added a commit
that referenced
this pull request
Apr 20, 2014
Give users an error when they use a value matcher in a block expectation expression
HoneyryderChuck
pushed a commit
to HoneyryderChuck/rspec-html-matchers
that referenced
this pull request
May 24, 2014
…a block (more information: rspec/rspec-expectations#530)
bf4
added a commit
to metricfu/metric_fu
that referenced
this pull request
Jun 2, 2014
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start of fix for #526.