Skip to content
This repository has been archived by the owner on Nov 30, 2024. It is now read-only.

Properly sub-class Exception so YARD can detect ExpectationNotMetError. #693

Merged
merged 1 commit into from
Dec 4, 2014
Merged

Properly sub-class Exception so YARD can detect ExpectationNotMetError. #693

merged 1 commit into from
Dec 4, 2014

Conversation

postmodern
Copy link
Contributor

rubydoc.org does not list ExpectationNotMetError as a class, but instead a plain constant.

@JonRowe
Copy link
Member

JonRowe commented Dec 4, 2014

Travis has this as passing, appveyor is having a fit about rubygems so ignoring that for now and merging. Thanks @postmodern

JonRowe added a commit that referenced this pull request Dec 4, 2014
Properly sub-class Exception so YARD can detect ExpectationNotMetError.
@JonRowe JonRowe merged commit fb35c58 into rspec:master Dec 4, 2014
JonRowe added a commit that referenced this pull request Dec 4, 2014
Properly sub-class Exception so YARD can detect ExpectationNotMetError.
@JonRowe
Copy link
Member

JonRowe commented Dec 4, 2014

Cherrypicked to 3-1-maintenance so future releases will have docs updated. No changelog because I class this as an internal refactoring.

yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this pull request Oct 6, 2021
…ostmodern/master

Properly sub-class Exception so YARD can detect ExpectationNotMetError.

---
This commit was imported from rspec/rspec-expectations@d114e4d.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants