Keyword argument warning on Ruby 2.7 for #and_call_original

[jaynetics]

Subject of the issue

#and_call_original with keyword arguments causes the following warning:

~/.rbenv/versions/2.7.0/lib/ruby/gems/2.7.0/gems/rspec-mocks-3.9.0/lib/rspec/mocks/message_expectation.rb:101: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call

Your environment

• Ruby version: 2.7.0
• rspec-expectations version: 3.9.0

Steps to reproduce

require 'rspec'

class Foo
  def initialize(bar: nil); end
end

RSpec.describe Foo do
  it 'works' do
    expect(Foo).to receive(:new).with(bar: :qux).and_call_original
    Foo.new(bar: :qux)
  end
end

RSpec::ExampleGroups::Foo.run

Expected behavior

No warning is emitted.

Actual behavior

A warning is emitted.

[JonRowe]

@jaynetics sorry it took so long but #1324 should take of this warning

[jonspalmer]

Any news on this one?

[pirj]

@jonspalmer Thanks for the reminder!

[G-Rath]

Any further news on this? We'd like to get on Ruby 2.7.1 and this is the only "blocker" (not a showstopper, but would be nice to have resolved).

[bestwebua]

The same issue, any updates?

[JonRowe]

Its on the list of things the team are working on and as always PRs are welcome.

[ioquatix]

It looks like this is now broken on Ruby 3. I'm happy to take a look, but I guess I don't know what the current status is.

[pirj]

@ioquatix No work is done on this front yet, we're focusing on preparing 4.0 release. Would be happy to include kwargs delegation fixes along with it.

If you can spare some time, here are notable things to get you going. Most importantly, it seems that using ruby2_keywords is the only choice. See:

• Keyword args support causes expected values to coerce to Hash rspec-expectations#1241 (comment)
• Regression in rspec-expectations 3.9.3 if argument to predicate method implements to_hash rspec-expectations#1221 (comment)

[JonRowe]

Work has been done on this but it slipped through the cracks, in part because we don't have specs for a lot of the keyword argument usage. Any keyword argument specs that can be provided which now fail I'll happily fix and take priority over releasing RSpec 4 so people can use Ruby 3 while we work on it.

[pirj]

@ioquatix Have you had a chance to take a look? No stress, we're going to pair on this with @benoittgt, just to avoid doing duplicate work.