Add request generator #1378
Merged
Add request generator #1378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes a generator for "request" specs. There already exists a generator which creates these specs, but it is called "integration". The existing name comes from the legacy implementations attempting to mirror the Rails test style names for the RSpec equivalent specs. Since these two generators are identical, except for the name, this makes the new `RequestGenerator` a subclass of the existing `IntegrationGenerator`. Alternatively, we could have decided to make `RequestGenerator` the parent class, moving the existing functionality into it. While this is arguably the "proper" way of thinking about the generators, it could potentially break some existing applications; even though these classes are marked `private`. There's no harm for now in keeping semver compliant by making this generator additive. Since the two generators are exactly the same this uses a shared example to keep the specs in-sync. Resolve #1377
This updates the existing generator specs: - Remove old `require 'spec_helper'`; `.rspec` does this now - Do not use the monkey patch version of `describe` - Use the generator support macros for the shared common setup
|
LGTM :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a generator for "request" specs. There already exists a
generator which creates these specs, but it is called "integration".
The existing name comes from the legacy implementations attempting to
mirror the Rails test style names for the RSpec equivalent specs.
Since these two generators are identical, except for the name, this
makes the new
RequestGeneratora subclass of the existingIntegrationGenerator. Alternatively, we could have decided to makeRequestGeneratorthe parent class, moving the existing functionalityinto it. While this is arguably the "proper" way of thinking about the
generators, it could potentially break some existing applications; even
though these classes are marked
private. There's no harm for now inkeeping semver compliant by making this generator additive.
Since the two generators are exactly the same this uses a shared example
to keep the specs in-sync.
Resolve #1377