Define url_options as per system test case does #2329
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnc
reviewed
May 9, 2020
|
I don't have anymore timeout with the PR, but I had no timeout with I think the problem is related to this: If you do : --- a/Gemfile
+++ b/Gemfile
@@ -5,6 +5,9 @@ ruby '2.6.6'
# Bundle edge Rails instead: gem 'rails', github: 'rails/rails'
gem 'rails', '6.0.0.rc1'
+gem 'actionpack', '6.0.0.rc1'
+gem 'activesupport', '6.0.0.rc1'
+gem 'railties', '6.0.0.rc1'You do no have the timeout anymore. 🤔 |
|
@benoittgt Rails 6.0.0.rc1 doesn't have the timeout issue because the problem was first introduced in Rails 6.0.1.rc1. Everything before that, including 6.0.0.rc1 is OK for me as well. |
Sorry... 🤦 |
JonRowe
force-pushed
the
fix-system-examples-default-host
branch
3 times, most recently
from
443fa2b
to
429160d
Compare
benoittgt
reviewed
May 10, 2020
| @@ -106,4 +106,4 @@ Feature: System spec | |||
| When I run `rspec spec/system/widget_system_spec.rb` | |||
| Then the output should contain "1 example, 0 failures" | |||
| And the output should not contain "starting Puma" | |||
| And the exit status should be 0 | |||
| And the exit status should be 0 or I debug | |||
There was a problem hiding this comment.
If you understand why, I am interested. I wrote this #2325 (comment)
JonRowe
force-pushed
the
fix-system-examples-default-host
branch
from
429160d
to
7d0a9af
Compare
JonRowe
force-pushed
the
fix-system-examples-default-host
branch
2 times, most recently
from
49b14cb
to
0623e8a
Compare
JonRowe
force-pushed
the
fix-system-examples-default-host
branch
from
0623e8a
to
1b0cc7b
Compare
JonRowe
force-pushed
the
fix-system-examples-default-host
branch
from
1b0cc7b
to
08182d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails switched to manually defining
url_optionswhen they switched away from inheriting from integration test case.See:
rails/rails@ea77dbf#diff-ff5f366a442b8761d35f94807700fa77R162
This should fix #2327