-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove predicates that apply to unsupported Rubies #2381
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pirj for the cleaning.
Ok for me because errors are Yard related.
I don't think we should merge this because its much easier to keep as much of the build in sync with rspec-dev as possible, yes there are some superfluous predicates but its easier to update this file with the others if one we use does change? |
The only two useful ones are |
Yes and when we move to RSpec 4 we can drop the functions for all repos, my point is that they are currently (to the best of my knowledge) still synced by the update pr, thus to reduce the risk of churn we can leave the unused functions. |
The update PR applies in the part of the common plaintext files, but not travis, rubocop and scripts I believe.
If it happens soon, there won't be much in that release besides dropping older Rubies 😆 Anyway, I don't mind closing this, as I work on a couple more cleanups already, it just caught my eye, and I couldn't resist sending this. Do you guys happen to know what is causing this |
d78ccea
to
fa57bf5
Compare
I was wrong with the removal of |
fa57bf5
to
1d93976
Compare
You joke but really thats one of the main purposes of a major release for us, we've talked about that being a thing.
Closing for now.
No but I don't think its a coincidence that we've recently merged an generator that uses this... |
No description provided.