-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using globally exposed DSL #2420
Conversation
@@ -1,6 +1,6 @@ | |||
require 'pathname' | |||
|
|||
shared_examples_for "an rspec-rails example group mixin" do |type, *paths| | |||
RSpec.shared_examples_for "an rspec-rails example group mixin" do |type, *paths| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that we require spec support files before RSpec.configure
, and Core::DSL.expose_globally!
was taking precedence. Interesting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds about right
This is fine, but do you mind not merging until I've released a release for 6.1? |
(As RSpec 4 will be sometime in the new year I suspect) |
eb8c582
to
253de2c
Compare
a947d64
to
088bd0a
Compare
I had to make yet another change here, check If @JonRowe Do you mind if I merge this before we release The usage of globally exposed DSL and removed - clone_repo "rspec-rails" "main"
+ clone_repo "rspec-rails" "remove-monkey-patching" |
Thanks! |
Stop using globally exposed DSL
I find it puzzling to explain why DSL was exposedThis PR is a prerequisite for: