Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap tests in Rails executor when configured #2753

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Wrap tests in Rails executor when configured #2753

wants to merge 5 commits into from

Commits on Apr 10, 2024

  1. Wrap examples with Rails executor 

    This recreates rspec#2712 since the GHA logs are no longer available which we need to address this issue. We should be wrapping the Rails examples with the executor to mimic what Rails v7 does (as noted in rspec#2713) to properly reset state. This has been tested in a test suite for an app but we need to address what issues there is within rspec-rails. This change request originated from rspec#2503 and rspec#2752 which the latter is meant as a temporary fix since this is the expected way to reset state.
    @javierjulio @JonRowe
    javierjulio authored and JonRowe committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    b430027 View commit details
    Browse the repository at this point in the history

  2. Account for Rails config default switch 

    From: https://github.com/rspec/rspec-rails/pull/2712/files#r1425001008
    @javierjulio @JonRowe
    javierjulio authored and JonRowe committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    f35b3a6 View commit details
    Browse the repository at this point in the history

  3. Account for all known cases 

    This now matches what Rails 7+ does
    @javierjulio @JonRowe
    javierjulio authored and JonRowe committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    13958cc View commit details
    Browse the repository at this point in the history

  4. Merge branch 'rspec:main' into patch-2

    @javierjulio
    javierjulio authored Apr 10, 2024
    Configuration menu
    Copy the full SHA
    9622d9b View commit details
    Browse the repository at this point in the history

  5. Update require/include statements

    @javierjulio
    javierjulio authored Apr 10, 2024
    Configuration menu
    Copy the full SHA
    0cf0662 View commit details
    Browse the repository at this point in the history