-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Ruby < 2.3 support #436
Merged
Merged
Commits on Dec 12, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 75149f3 - Browse repository at this point
Copy the full SHA 75149f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c2c610 - Browse repository at this point
Copy the full SHA 7c2c610View commit details -
We always test against 9.0+, 9.2 actually, and 9.2 is recommended for all users, there's no excuse to be using 9.0 or 9.1
Configuration menu - View commit details
-
Copy full SHA for 2f3489e - Browse repository at this point
Copy the full SHA 2f3489eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3842f17 - Browse repository at this point
Copy the full SHA 3842f17View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26ca803 - Browse repository at this point
Copy the full SHA 26ca803View commit details -
Configuration menu - View commit details
-
Copy full SHA for 514ce68 - Browse repository at this point
Copy the full SHA 514ce68View commit details -
Configuration menu - View commit details
-
Copy full SHA for 87dca93 - Browse repository at this point
Copy the full SHA 87dca93View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8109750 - Browse repository at this point
Copy the full SHA 8109750View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba17eca - Browse repository at this point
Copy the full SHA ba17ecaView commit details -
Configuration menu - View commit details
-
Copy full SHA for a372762 - Browse repository at this point
Copy the full SHA a372762View commit details -
Configuration menu - View commit details
-
Copy full SHA for 67f560d - Browse repository at this point
Copy the full SHA 67f560dView commit details -
Remove JRuby arity check workaround
Java::JavaLang::String.instance_method(:char_at).arity evaluates to 1 on JRuby 9.2(.13.0)
Configuration menu - View commit details
-
Copy full SHA for c6257e9 - Browse repository at this point
Copy the full SHA c6257e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a9c58a - Browse repository at this point
Copy the full SHA 2a9c58aView commit details -
Configuration menu - View commit details
-
Copy full SHA for cd8b41e - Browse repository at this point
Copy the full SHA cd8b41eView commit details -
Configuration menu - View commit details
-
Copy full SHA for ad44a2e - Browse repository at this point
Copy the full SHA ad44a2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for ffd4518 - Browse repository at this point
Copy the full SHA ffd4518View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d1270d - Browse repository at this point
Copy the full SHA 1d1270dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3496910 - Browse repository at this point
Copy the full SHA 3496910View commit details -
Configuration menu - View commit details
-
Copy full SHA for 81e4713 - Browse repository at this point
Copy the full SHA 81e4713View commit details -
Configuration menu - View commit details
-
Copy full SHA for e91cc38 - Browse repository at this point
Copy the full SHA e91cc38View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e36bd3 - Browse repository at this point
Copy the full SHA 7e36bd3View commit details -
Configuration menu - View commit details
-
Copy full SHA for e072219 - Browse repository at this point
Copy the full SHA e072219View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9939949 - Browse repository at this point
Copy the full SHA 9939949View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9c5674 - Browse repository at this point
Copy the full SHA b9c5674View commit details
Commits on Dec 14, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 69288f3 - Browse repository at this point
Copy the full SHA 69288f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b2467f - Browse repository at this point
Copy the full SHA 1b2467fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b66b7c8 - Browse repository at this point
Copy the full SHA b66b7c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 571a692 - Browse repository at this point
Copy the full SHA 571a692View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c3c74e - Browse repository at this point
Copy the full SHA 0c3c74eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a92dc58 - Browse repository at this point
Copy the full SHA a92dc58View commit details -
Configuration menu - View commit details
-
Copy full SHA for b69244f - Browse repository at this point
Copy the full SHA b69244fView commit details -
Configuration menu - View commit details
-
Copy full SHA for fdd801c - Browse repository at this point
Copy the full SHA fdd801cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d181a28 - Browse repository at this point
Copy the full SHA d181a28View commit details -
Remove StdErrSplitter workarounds
Kept gems warning muted due to: 1. RuntimeError: Warnings were generated: /home/runner/work/rspec-support/bundle/ruby/2.5.0/gems/actioncable-6.0.3.4/lib/action_cable/channel/test_case.rb:178: warning: method redefined; discarding old connection Shared Example Group: "an rspec-rails example group mixin" called from ./spec/rspec/rails/example/channel_example_group_spec.rb:6 # /home/runner/work/rspec-support/rspec-support/lib/rspec/support/spec/stderr_splitter.rb:38:in `verify_no_warnings!' 2. RuntimeError: Warnings were generated: /home/runner/work/rspec-support/bundle/ruby/2.5.0/gems/actionpack-6.0.3.4/lib/action_dispatch/routing/route_set.rb:560: warning: instance variable @_routes not initialized Shared Example Group: "an rspec-rails example group mixin" called from ./spec/rspec/rails/example/view_example_group_spec.rb:5 # /home/runner/work/rspec-support/rspec-support/lib/rspec/support/spec/stderr_splitter.rb:38:in `verify_no_warnings!'
Configuration menu - View commit details
-
Copy full SHA for dd56e6f - Browse repository at this point
Copy the full SHA dd56e6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 38885cf - Browse repository at this point
Copy the full SHA 38885cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for a9ab522 - Browse repository at this point
Copy the full SHA a9ab522View commit details -
Configuration menu - View commit details
-
Copy full SHA for 048eedd - Browse repository at this point
Copy the full SHA 048eeddView commit details -
Configuration menu - View commit details
-
Copy full SHA for a787fa2 - Browse repository at this point
Copy the full SHA a787fa2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d41dfa - Browse repository at this point
Copy the full SHA 0d41dfaView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.