Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Ruby < 2.3 support #436

Merged
merged 39 commits into from
Dec 15, 2020
Merged

Drop Ruby < 2.3 support #436

merged 39 commits into from
Dec 15, 2020

Commits on Dec 12, 2020

  1. Simplify fork_supported?

    @pirj
    pirj committed Dec 12, 2020
    Configuration menu
    Copy the full SHA
    75149f3 View commit details
    Browse the repository at this point in the history

  2. Simplify ripper_supported?

    @pirj
    pirj committed Dec 12, 2020
    Configuration menu
    Copy the full SHA
    7c2c610 View commit details
    Browse the repository at this point in the history

  3. Remove redundant jruby_9000? 

    We always test against 9.0+, 9.2 actually, and 9.2 is recommended for
all users, there's no excuse to be using 9.0 or 9.1
    @pirj
    pirj committed Dec 12, 2020
    Configuration menu
    Copy the full SHA
    2f3489e View commit details
    Browse the repository at this point in the history

  4. Remove kw_args_supported?

    @pirj
    pirj committed Dec 12, 2020
    Configuration menu
    Copy the full SHA
    3842f17 View commit details
    Browse the repository at this point in the history

  5. Remove supports_rebinding_module_methods?

    @pirj
    pirj committed Dec 12, 2020
    Configuration menu
    Copy the full SHA
    26ca803 View commit details
    Browse the repository at this point in the history

  6. Remove required_kw_args_supported?

    @pirj
    pirj committed Dec 12, 2020
    Configuration menu
    Copy the full SHA
    514ce68 View commit details
    Browse the repository at this point in the history

  7. Always use require_relative

    @pirj
    pirj committed Dec 12, 2020
    Configuration menu
    Copy the full SHA
    87dca93 View commit details
    Browse the repository at this point in the history

  8. Remove optional_and_splat_args_supported?

    @pirj
    pirj committed Dec 12, 2020
    Configuration menu
    Copy the full SHA
    8109750 View commit details
    Browse the repository at this point in the history

  9. Remove caller_locations_supported?

    @pirj
    pirj committed Dec 12, 2020
    Configuration menu
    Copy the full SHA
    ba17eca View commit details
    Browse the repository at this point in the history

  10. Remove supports_exception_cause?

    @pirj
    pirj committed Dec 12, 2020
    Configuration menu
    Copy the full SHA
    a372762 View commit details
    Browse the repository at this point in the history

  11. Remove unused module_refinement_supported?

    @pirj
    pirj committed Dec 12, 2020
    Configuration menu
    Copy the full SHA
    67f560d View commit details
    Browse the repository at this point in the history

  12. Remove JRuby arity check workaround 

    Java::JavaLang::String.instance_method(:char_at).arity evaluates to 1 on
JRuby 9.2(.13.0)
    @pirj
    pirj committed Dec 12, 2020
    Configuration menu
    Copy the full SHA
    c6257e9 View commit details
    Browse the repository at this point in the history

  13. Remove 1.8.7-specific workaround

    @pirj
    pirj committed Dec 12, 2020
    Configuration menu
    Copy the full SHA
    2a9c58a View commit details
    Browse the repository at this point in the history

  14. Remove JRuby in 1.8.7 compat mode workaround

    @pirj
    pirj committed Dec 12, 2020
    Configuration menu
    Copy the full SHA
    cd8b41e View commit details
    Browse the repository at this point in the history

  15. Remove 1.9 Open3 workaround

    @pirj
    pirj committed Dec 12, 2020
    Configuration menu
    Copy the full SHA
    ad44a2e View commit details
    Browse the repository at this point in the history

  16. Remove module_prepends_supported?

    @pirj
    pirj committed Dec 12, 2020
    Configuration menu
    Copy the full SHA
    ffd4518 View commit details
    Browse the repository at this point in the history

  17. Remove String#encoding workarounds

    @pirj
    pirj committed Dec 12, 2020
    Configuration menu
    Copy the full SHA
    1d1270d View commit details
    Browse the repository at this point in the history

  18. Remove Time#nsec workaround

    @pirj
    pirj committed Dec 12, 2020
    Configuration menu
    Copy the full SHA
    3496910 View commit details
    Browse the repository at this point in the history

  19. Remove 1.9.2-specific workaround

    @pirj
    pirj committed Dec 12, 2020
    Configuration menu
    Copy the full SHA
    81e4713 View commit details
    Browse the repository at this point in the history

  20. Simplify a macro definition

    @pirj
    pirj committed Dec 12, 2020
    Configuration menu
    Copy the full SHA
    e91cc38 View commit details
    Browse the repository at this point in the history

  21. Update required Ruby version gemspec constraint

    @pirj
    pirj committed Dec 12, 2020
    Configuration menu
    Copy the full SHA
    7e36bd3 View commit details
    Browse the repository at this point in the history

  22. Remove explicit gem version constraints

    @pirj
    pirj committed Dec 12, 2020
    Configuration menu
    Copy the full SHA
    e072219 View commit details
    Browse the repository at this point in the history

  23. Remove assorted older rubies workarounds

    @pirj
    pirj committed Dec 12, 2020
    Configuration menu
    Copy the full SHA
    9939949 View commit details
    Browse the repository at this point in the history

  24. Explicitly require ruby_features where needed

    @pirj
    pirj committed Dec 12, 2020
    Configuration menu
    Copy the full SHA
    b9c5674 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2020

  1. Remove const_defined? workaround

    @pirj
    pirj committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    69288f3 View commit details
    Browse the repository at this point in the history

  2. Remove version-specific details from a doc

    @pirj
    pirj committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    1b2467f View commit details
    Browse the repository at this point in the history

  3. Remove old JRuby workaround

    @pirj
    pirj committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    b66b7c8 View commit details
    Browse the repository at this point in the history

  4. Remove usages of jruby_9000

    @pirj
    pirj committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    571a692 View commit details
    Browse the repository at this point in the history

  5. Remove non_mri?

    @pirj
    pirj committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    0c3c74e View commit details
    Browse the repository at this point in the history

  6. Add Changelog entry

    @pirj
    pirj committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    a92dc58 View commit details
    Browse the repository at this point in the history

  7. Get rid of evals

    @pirj
    pirj committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    b69244f View commit details
    Browse the repository at this point in the history

  8. Fix offences

    @pirj
    pirj committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    fdd801c View commit details
    Browse the repository at this point in the history

  9. Use Mutex from core, prevent it from being stubbed

    @pirj
    pirj committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    d181a28 View commit details
    Browse the repository at this point in the history

  10. Remove StdErrSplitter workarounds 

    Kept gems warning muted due to:

1.

      RuntimeError:
       Warnings were generated: /home/runner/work/rspec-support/bundle/ruby/2.5.0/gems/actioncable-6.0.3.4/lib/action_cable/channel/test_case.rb:178: warning: method redefined; discarding old connection
     Shared Example Group: "an rspec-rails example group mixin" called from ./spec/rspec/rails/example/channel_example_group_spec.rb:6
     # /home/runner/work/rspec-support/rspec-support/lib/rspec/support/spec/stderr_splitter.rb:38:in `verify_no_warnings!'

2.
       RuntimeError:
        Warnings were generated: /home/runner/work/rspec-support/bundle/ruby/2.5.0/gems/actionpack-6.0.3.4/lib/action_dispatch/routing/route_set.rb:560: warning: instance variable @_routes not initialized
      Shared Example Group: "an rspec-rails example group mixin" called from ./spec/rspec/rails/example/view_example_group_spec.rb:5
      # /home/runner/work/rspec-support/rspec-support/lib/rspec/support/spec/stderr_splitter.rb:38:in `verify_no_warnings!'
    @pirj
    pirj committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    dd56e6f View commit details
    Browse the repository at this point in the history

  11. Remove redundant boilerplate

    @pirj
    pirj committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    38885cf View commit details
    Browse the repository at this point in the history

  12. Remove BasicObject checks

    @pirj
    pirj committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    a9ab522 View commit details
    Browse the repository at this point in the history

  13. Remove filtering for unsupported rubies

    @pirj
    pirj committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    048eedd View commit details
    Browse the repository at this point in the history

  14. Fix code doc

    @pirj
    pirj committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    a787fa2 View commit details
    Browse the repository at this point in the history

  15. Downgrade ffi due to their usage of Gem

    @pirj
    pirj committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    0d41dfa View commit details
    Browse the repository at this point in the history