This repository has been archived by the owner on Nov 30, 2024. It is now read-only.
Use Mutex#owned? to correctly check if the Mutex is owned by the current Thread or Fiber #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent Thread or Fiber * In Ruby >= 3, Mutex are held per Fiber, not per Thread. * Fixes #501
|
Green on the first try! |
JonRowe
approved these changes
Apr 29, 2021
JonRowe
added a commit
that referenced
this pull request
Apr 29, 2021
Use Mutex#owned? to correctly check if the Mutex is owned by the current Thread or Fiber
|
Thanks, Jon! |
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…eentrant-mutex-fiber-3.0 Use Mutex#owned? to correctly check if the Mutex is owned by the current Thread or Fiber --- This commit was imported from rspec/rspec-support@4ad8392.
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…eentrant-mutex-fiber-3.0 Use Mutex#owned? to correctly check if the Mutex is owned by the current Thread or Fiber --- This commit was imported from rspec/rspec-support@77269e4.
|
Has this been released yet? |
|
Oh, was this released 3 days ago? I still seem to experience some hangs in some cases, so maybe I need to investigate. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Ruby >= 3, Mutex are held per Fiber, not per Thread.
Fixes #501
This is a backport of #503 for RSpec 3