Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Relish's links #177

Closed
wants to merge 1 commit into from
Closed

Fix Relish's links #177

wants to merge 1 commit into from

Conversation

urimaro
Copy link

@urimaro urimaro commented Jan 11, 2023

The link to Relish is broken.

https://rspec.info/documentation/

This PR adds the following links because Relish does not have RSpec page.

  • rspec-core
  • rspec-expectations
  • rspec-mocks
  • rspec-rails

@pirj
Copy link
Member

pirj commented Jan 11, 2023

It's not that it's the link is broken, it's something that is broken on Relish side.
Do you mind keeping the original link?

@JonRowe
Copy link
Member

JonRowe commented Jan 11, 2023

The rspec link should actually work, but is currently offline for some reason, so I'm on the fence, as this isn't harmful but...

@JonRowe
Copy link
Member

JonRowe commented Jan 11, 2023

I actually wonder given that Relish is being sunset and we've made no progress on moving to its replacement, wether we should have a way of generating our own "relish" style pages and self hosting them...

@pirj
Copy link
Member

pirj commented Jan 12, 2023

I've booked time with Matt next Monday to fix the failing page.

generating our own "relish" style pages and self hosting them

Quite reasonable. Wondering how those pages are generated in the first place, I'll ask.

@urimaro
Copy link
Author

urimaro commented Jan 28, 2023

@pirj
Please let us know the summary of your conversation if you can.
If the direction is not decided, how about following ideas

  • Merge this or merge this after improvement
  • When the issue on Relish is resolved, revert the merged pull request

To make users easier to access RSpec’s info, I made this PR.
So if you don’t think this PR does not improve accessibility, closing this PR is OK.

@pirj
Copy link
Member

pirj commented Jan 28, 2023

My apologies, this pr slipped my mind.
Issue with that endpoint is resolved.

@pirj pirj closed this Jan 28, 2023
@pirj
Copy link
Member

pirj commented Jan 28, 2023

An idea for doc generation, or a pr with a pipeline to publish docs with e.g Antora is welcome.

@urimaro
Copy link
Author

urimaro commented Feb 1, 2023

Thank you for your efforts.☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants