Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for netstandard2.0 #30

Merged
merged 3 commits into from
Dec 5, 2019
Merged

Support for netstandard2.0 #30

merged 3 commits into from
Dec 5, 2019

Conversation

isaacabraham
Copy link
Collaborator

@isaacabraham isaacabraham commented Aug 6, 2019 •
edited
Loading

This add basic support for netstandard2.0. I don't know what else is required - probably upping the version number and some other testing.

Linked to #29

@isaacabraham
Copy link
Collaborator Author

isaacabraham commented Nov 22, 2019 •
edited
Loading

@slang25 @forki do you think that this is good to go? I've tested by created a local version of the package, it seemed to work with Paket at least.

I imagine a new version number needs to be set and perhaps some other things as well.

forki
forki approved these changes Nov 22, 2019
View reviewed changes
Copy link

@forki forki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slang25
Copy link

slang25 commented Nov 23, 2019

👍 Looks good

@isaacabraham
Copy link
Collaborator Author

I've tested this locally and it seems to work, although I had to delete the Directory.Build.Props file to get it to compile (I suspect that this is environmental). @rspeele assuming you're happy with this, what's the next step required to push it to nuget?

@rspeele rspeele merged commit c97bb6d into rspeele:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forki forki forki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@isaacabraham @slang25 @forki @rspeele