Recognize "@" in gender-neutral word endings as part of the token #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tahnan
reviewed
Jul 23, 2018
CHANGELOG.md
Outdated
| @@ -1,3 +1,5 @@ | |||
| ## Version 2.2 | |||
|
|
|||
There was a problem hiding this comment.
It looks like this section still needs to be written?
There was a problem hiding this comment.
Ah yeah. I started thinking I should write it, then changed my mind because I didn't know what date to put on it, and decided I'd write it after the PR was merged. But then I left it like this. I could just write the section and put tomorrow's date on it.
rspeer
pushed a commit
that referenced
this pull request
Jun 25, 2024
Recognize "@" in gender-neutral word endings as part of the token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the big tokenization regex to handle cases where
@or@sappears at the end of the word. The regex now works around Unicode's default segmentation to treat this@as a letter, because this is a way of writing gender-neutral word endings in Spanish, Portuguese, and particularly far-left Italian.As an example, the text
"l@s niñ@s"should be tokenized as["l@s", "niñ@s"], not as["l", "s", "niñ", "s"].The endings "x" and "xs" are becoming more common in Spanish for this purpose, but these are already tokenized correctly. On the other hand, only the "@" version is attested in Portuguese. This steered me away from my initial plan to replace "@" with "x" in these endings in a pre-processing step.
This version now includes the new data from exquisite-corpus, so it has the words with @ in them, as well as some cleaner data from ParaCrawl.