Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Node/Ruby versions #2125

Merged
merged 2 commits into from
Mar 24, 2024
Merged

Update Node/Ruby versions #2125

merged 2 commits into from
Mar 24, 2024

Conversation

rstacruz
Copy link
Owner

@rstacruz rstacruz commented Mar 24, 2024 •
edited
Loading

Context

  • Issue 1: There are different Node.js versions defined in .node-version, package.json, etc
  • Issue 2: it would be nice to have Cloudflare Pages deploy previews, but the inconsistency in versions doesn't really work well with Cloudflare Pages

Solution

  • Update .node-version
  • Update .ruby-version
  • Update GitHub actions

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Mar 24, 2024 •
edited
Loading

Deploying devhints-io with  Cloudflare Pages  Cloudflare Pages

Latest commit: e3aa346
Status: ✅  Deploy successful!
Preview URL: https://226a6656.devhints-io.pages.dev
Branch Preview URL: https://dev-2024-03-24-cfpages-compa.devhints-io.pages.dev

View logs

@rstacruz rstacruz merged commit 2ac6e0e into master Mar 24, 2024
7 checks passed
@delete-merged-branch delete-merged-branch bot deleted the dev-2024-03-24-cfpages-compatibility branch March 24, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rstacruz